On Saturday 09 June 2007, Alex Riesen wrote: > On 6/9/07, Johan Herland <johan@xxxxxxxxxxx> wrote: > > Signed-off-by: Johan Herland <johan@xxxxxxxxxxx> > > --- > > mktag.c | 29 ++++++++++++++++------------- > > 1 files changed, 16 insertions(+), 13 deletions(-) > > What is this change good for? > How did you justify the type selection for your > loop index variable? > > IOW, the patch looks very useless. I agree. By itself, the patch is useless. However, if you look at the next patch, you'll see that this exact piece of code is moved from verify_tag() to parse_and_verify_tag_buffer(), and in the new context, we can't increment tag_line, since the code that follows depends on tag_line not being moved. In other words this patch is here so that the next patch will be easier to follow. because it's _literally_ moving copying code from verify_tag() and pasting it in parse_and_verify_tag_buffer(). I'm sorry if this is not clear from the patches. ...Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
