The "What's cooking" email carried this series for some time now:
> * pc/submodule-helper-foreach (2018-02-02) 5 commits
> - submodule: port submodule subcommand 'foreach' from shell to C
> - submodule foreach: document variable '$displaypath'
> - submodule foreach: clarify the '$toplevel' variable documentation
> - submodule foreach: document '$sm_path' instead of '$path'
> - submodule foreach: correct '$path' in nested submodules from a subdirectory
>
> Expecting a response to review comments
> e.g. cf. <20180206150044.1bffbb573c088d38c8e44bf5@xxxxxxxxxx>
I reworded the commit message of the first patch and nearly confused
myself again, as "toplevel" doesn't refer to the "topmost" superproject,
just the direct superproject of the submodule.
However I think the code of the first patch is correct as originally presented.
Just the wording of the commit message was changed to explain the reasoning
more extensively.
With this series, we get
* keep the invariant of $toplevel + $path to be an absolute path that is
correctly pointing at the submodule. "git -C $toplevel config" + $name
allowing to ask configuration of the submodule.
* $displaypath will have the relative path form $pwd to the submodule root.
* better documentation.
In later patches we could add $topmost, that points at the superproject
in which the command was started from, and $path_from_topmost, that would
be the relative path from $topmost to the submodule, potentially skipping
intermediate superprojects.
Thanks,
Stefan
Prathamesh Chavan (5):
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path'
submodule foreach: clarify the '$toplevel' variable documentation
submodule foreach: document variable '$displaypath'
submodule: port submodule subcommand 'foreach' from shell to C
Documentation/git-submodule.txt | 15 ++--
builtin/submodule--helper.c | 148 ++++++++++++++++++++++++++++++++
git-submodule.sh | 40 +--------
t/t7407-submodule-foreach.sh | 38 +++++++-
4 files changed, 194 insertions(+), 47 deletions(-)
--
2.17.0.441.gb46fe60e1d-goog
