Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > On Mon, Apr 30, 2018 at 1:30 PM, Casey Fitzpatrick <kcghost@xxxxxxxxx> wrote: >> It also seems to be missing "--progress", and I imagine others. >> Perhaps submodule add/update should be reworked to automatically >> accept all the options that clone would? > > --progress is not missing, but I see that it isn't documented. It was > added in 72c5f88311 ("clone: pass --progress decision to recursive > submodules", 2016-09-22). What you're suggesting makes sense, but as > shown in that commit it's not easy for it to happen automatically, > there's a lot of boilerplate involved. > > But since you're interested you can see how to add new options with > that patch, it should be easy for anyone not experienced with the > codebase, it's all just boilerplate + adding a test. I think it is going in the right direction overall, but a few corner cases may need special attention. "add" may be adding a new module that locally originates, in which case "clone" is not relevant. Similarly, for "update"options for "clone" are not relevant unless it is the very initial one.