This is the thirteenth series of patches to convert to struct object_id and the_hash_algo. The series adds an oidread function to read object IDs from a buffer, removes unused structure members (which therefore don't require conversion), converts various functions to struct object_id, and improves usage of the_hash_algo. It also makes empty_blob_oid and empty_tree_oid static, exposed only through the hash algorithm abstraction, and updates all the hard-coded instances of the empty blob and empty tree object IDs in scripts (excepting the testsuite). Changes from v1: * Add missing sign-off. * Removed unneeded braces from init_pack_info. * Express 51 in terms of the_hash_algo->hexsz. * Fix comments referring to SHA-1. * Update commit messages as suggested. * Add and use empty_tree_oid_hex and empty_blob_oid_hex. brian m. carlson (42): cache: add a function to read an object ID from a buffer server-info: remove unused members from struct pack_info Remove unused member in struct object_context packfile: remove unused member from struct pack_entry packfile: convert has_sha1_pack to object_id sha1-file: convert freshen functions to object_id packfile: convert find_pack_entry to object_id packfile: abstract away hash constant values pack-objects: abstract away hash algorithm pack-redundant: abstract away hash algorithm tree-walk: avoid hard-coded 20 constant tree-walk: convert get_tree_entry_follow_symlinks to object_id fsck: convert static functions to struct object_id submodule-config: convert structures to object_id split-index: convert struct split_index to object_id Update struct index_state to use struct object_id pack-redundant: convert linked lists to use struct object_id index-pack: abstract away hash function constant commit: convert uses of get_sha1_hex to get_oid_hex dir: convert struct untracked_cache_dir to object_id http: eliminate hard-coded constants revision: replace use of hard-coded constants upload-pack: replace use of several hard-coded constants diff: specify abbreviation size in terms of the_hash_algo builtin/receive-pack: avoid hard-coded constants for push certs sha1-file: add functions for hex empty tree and blob OIDs builtin/am: convert uses of EMPTY_TREE_SHA1_BIN to the_hash_algo builtin/merge: switch tree functions to use object_id merge: convert empty tree constant to the_hash_algo sequencer: convert one use of EMPTY_TREE_SHA1_HEX submodule: convert several uses of EMPTY_TREE_SHA1_HEX wt-status: convert two uses of EMPTY_TREE_SHA1_HEX builtin/receive-pack: convert one use of EMPTY_TREE_SHA1_HEX builtin/reset: convert use of EMPTY_TREE_SHA1_BIN sha1_file: convert cached object code to struct object_id cache-tree: use is_empty_tree_oid sequencer: use the_hash_algo for empty tree object ID dir: use the_hash_algo for empty blob object ID sha1_file: only expose empty object constants through git_hash_algo Update shell scripts to compute empty tree object ID add--interactive: compute the empty tree value merge-one-file: compute empty blob object ID builtin/am.c | 8 +-- builtin/count-objects.c | 2 +- builtin/fsck.c | 2 +- builtin/index-pack.c | 3 +- builtin/merge.c | 14 ++--- builtin/pack-objects.c | 32 +++++------ builtin/pack-redundant.c | 62 +++++++++++---------- builtin/prune-packed.c | 2 +- builtin/receive-pack.c | 8 +-- builtin/reset.c | 2 +- builtin/rev-parse.c | 4 +- cache-tree.c | 4 +- cache.h | 28 ++++------ commit.c | 4 +- diff.c | 20 ++++--- dir.c | 25 ++++----- dir.h | 5 +- fsck.c | 20 +++---- git-add--interactive.perl | 11 +++- git-filter-branch.sh | 4 +- git-merge-one-file.sh | 2 +- git-rebase--interactive.sh | 4 +- http.c | 13 ++--- merge.c | 5 +- packfile.c | 79 ++++++++++++++------------- packfile.h | 4 +- read-cache.c | 34 ++++++------ resolve-undo.c | 2 +- revision.c | 7 +-- sequencer.c | 4 +- server-info.c | 9 +--- sha1-file.c | 81 +++++++++++++++++----------- sha1-name.c | 5 +- split-index.c | 10 ++-- split-index.h | 4 +- submodule-config.c | 66 +++++++++++------------ submodule-config.h | 7 +-- submodule.c | 6 +-- t/helper/test-dump-split-index.c | 4 +- t/helper/test-dump-untracked-cache.c | 2 +- templates/hooks--pre-commit.sample | 2 +- tree-walk.c | 18 +++---- tree-walk.h | 2 +- unpack-trees.c | 2 +- upload-pack.c | 18 +++---- wt-status.c | 4 +- 46 files changed, 348 insertions(+), 306 deletions(-)
