Jonas Fonseca wrote:
I've only played little with this patch, but overall I like most of the changes. I would, however, want to look into making the dependency on autoconf optional (like it is for git) and avoid using automake at all. It would make the autoconf.sh bootstrap script obsolete, since the Makefile can just take care of it, and it would keep the build system simple. So the idea is for configure to also generate a Makefile.config that can be sourced by the Makefile. Then of course inclusion of the config.h file should depend on some -DHAVE_CONFIG_H flag for the compiler. What do you think? You are of course welcome to come up with a patch for this proposal, but else I would like to get your permission/sign-off to include the configure.ac script and the tig.c changes you made.
That sounds perfectly sensible to me. Not sure when I'll have time to work on that proposal, but in the meantime you can use whatever bits of my original patch you like. Sorry about the lack of a Signed-off-by line in the original post -- I use git for private stuff at work 99% of the time and it sometimes slips my mind to add that extra header line for public changes. So, retroactively (though if you like I can resend the whole patch with this line):
Signed-off-by: Steven Grimm <koreth@xxxxxxxxxxxxx> -Steve - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
