On Mon, Apr 30, 2018 at 11:59:43PM +0000, brian m. carlson wrote: > > I guess I'll be helping review this series instead :D Overall I think this looks good. > > Yeah, I have code to fix that, but it's ugly. > > You can see the work on part2 and part3 of the test fixes, plus the > fixes for all of that stuff on my object-id-part14 branch. Since I gave it some thought, another way of dealing with this may be hiding this behind git_hash_algo abstraction, so we have one function for sha1, one for newhash... and they are probably just macros that take different struct definition. -- Duy
