On 4/30/2018 10:57 AM, Duy Nguyen wrote:
On Mon, Apr 30, 2018 at 4:26 PM, Ben Peart <Ben.Peart@xxxxxxxxxxxxx> wrote:Take advantage of the recent addition of support for lazy loading functions on Windows to simplfy the loading of NtSetSystemInformation. Signed-off-by: Ben Peart <benpeart@xxxxxxxxxxxxx> --- Notes: Base Ref: master Web-Diff: https://github.com/benpeart/git/commit/6e6ce4a788 Checkout: git fetch https://github.com/benpeart/git test-drop-caches-v1 && git checkout 6e6ce4a788 t/helper/test-drop-caches.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c index 838760898b..dd41da1a2c 100644 --- a/t/helper/test-drop-caches.c +++ b/t/helper/test-drop-caches.c @@ -1,5 +1,6 @@ #include "test-tool.h" #include "git-compat-util.h" +#include "lazyload.h"This is in compat/win32, should it be inside the "if defined (GIT_WINDOWS_NATIVE)" block instead of here?
Yes, that does make sense. No other platform will need/want it. I'll wait to see if there is any other feedback and will submit an updated patch. Thanks for the catch.
