"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > On Sun, Apr 29, 2018 at 09:40:13PM -0400, Patrick Hemmer wrote: >> When you use `git format-patch --cover-letter --attach`, the cover >> letter does not have the trailing MIME boundary. RFC2046 states that the >> last part must be followed by a closing boundary. This causes some email >> clients (Thunderbird in my case) to discard the message body. >> This is experienced with git 2.16.3. > > Thanks for reporting this. I can confirm this with a reasonably recent > next. Let me see if I can come up with a patch. Thanks. It is true that the current output from the tool is corrupt mime multi-part, and we need to do something about it. I however have to wonder if it even makes sense for --cover to pay attention to --attach and produce the cover template that has "BLURB HERE" etc. in a multi-part format. Shouldn't we be making a simple plain text file instead?