Hi Martin, On Sat, Apr 28, 2018 at 4:32 AM, Martin Ågren <martin.agren@xxxxxxxxx> wrote: > From: Elijah Newren <newren@xxxxxxxxx> > > Hi Elijah, > > [Since this is leaving the topic of rename-detection in favour of > leak-plugging, I'm shortening the cc-list a bit.] > >> So, instead, I'd like to see something like the below >> (built on top of my series): > > Thanks a lot. I now have the below patch in my tree as a preparatory > part of a three-patch series on top of your series. Since the gist of > this patch is entirely your creation, is it ok if I place your Author: > and Signed-off-by: on it? Credit where credit is due. Sure, I'm fine with either that or an Original-patch-by attribution. Anyway, thanks for fleshing it out with the commit message and handling the early return cases. And for tackling the setup_unpack_trees_porcelain() memory leak.