On Thu, Apr 26, 2018 at 4:24 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > Hence (1) we should detect and error out when --prefix-tags is used > with mirror fetch near where we do the same for track used without > mirror fetch already, (2) detect and error out when --prefix-tags is > used with track, and (3) add "+refs/tags/*:refs/remote-tags/$name/*" > just once without paying attention to track here. We may not even > want add_remote_tags() helper function if we go that route. > I've replied to the thread using format-email/send-email with the subject: "[RFC PATCH v2] Teach remote add the --prefix-tags option", but I misspelled Junio's email address :( I've tried to address the issues pointed out by Junio. But I've choosen not to do "(2) detect and error out when --prefix-tags is used with track". My thinking is tags are independent of tracking and it seems reasonable that they sould be included if requested. If I'm wrong I'll certainly fix it. The other change was rather than using ""+refs/tags/*:refs/remote-tags/$name/*" I've changed it to "+refs/tags/*:refs/remote/tags/$name/*" which seems cleaner. Again, if remote-tags is preferred I'll change it back. One other question, I'm not sure "--prefix-tags" is the best name for the option, maybe "--sub-tags" or "--nested-tags" or ... -- Wink
