On Tue, 24 Apr 2018 14:03:23 -0700 Stefan Beller <sbeller@xxxxxxxxxx> wrote: > v2: > I think I have addressed Jonathans feedback > * by using a string instead of counting the first character only. > * refined tests slightly (easier to read) > * moved white space handling for moved blocks into its own flag field, > keeping the enum for the actual mode of move detection. For reference, v1 is here: https://public-inbox.org/git/20180402224854.86922-1-sbeller@xxxxxxxxxx/ > Stefan Beller (7): > xdiff/xdiff.h: remove unused flags > xdiff/xdiffi.c: remove unneeded function declarations > diff.c: do not pass diff options as keydata to hashmap > diff.c: adjust hash function signature to match hashmap expectation > diff.c: add a blocks mode for moved code detection > diff.c: decouple white space treatment from move detection algorithm > diff.c: add --color-moved-ignore-space-delta option I'm not sure if we should add a new "blocks" mode, or if we should modify the existing plain mode to have the minimum block length instead. I reviewed the code as if we want the new "blocks" mode.
