On Tue, Apr 24, 2018 at 03:13:55PM +0900, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > > > I think when we add features to git-grep we should be as close to GNU > > grep as possible (e.g. not add this -m alias meaning something different > > as in your v1), but if GNU grep doesn't have something go with the trend > > of other grep tools, as noted at > > https://beyondgrep.com/feature-comparison/ (and I found another one that > > has this: https://github.com/beyondgrep/website/pull/83), so there's > > already 3 prominent grep tools that call this just --column. > > > > I think we should just go with that. > > OK. If they called it --column-number, that might have been more in > line with GNU grep's --line-number, but that is not something we can > dictate retroactively anyway, so --column to match them would be > better than trying to be consistent and ending up with being > different from everybody else. That sounds sensible. Let's call the new option '--column', and the configuration options grep.column and color.grep.column to match (instead of s/column/columnNumber/g), yes? Thanks, Taylor
