On Mon, 23 Apr 2018 16:43:20 -0700 Stefan Beller <sbeller@xxxxxxxxxx> wrote: > Add a repository argument to allow the callers of oid_object_info > to be more specific about which repository to handle. This is a small > mechanical change; it doesn't change the implementation to handle > repositories other than the_repository yet. >From here... > In the expanded macro the identifier `the_repository` is not actually used, > so the compiler does not catch if the repository.h header is not included > at the call site. call sites needing that #include were identified by > changing the macro to definition to > > #define sha1_object_info(r, sha1, size) \ > (r, sha1_object_info_##r(sha1, size)). > > This produces a compiler warning about the left hand side of the comma > operator being unused, which can be suppressed using -Wno-unused-value. > > To avoid breaking bisection, do not include this trick in the patch. ...until here: I don't think this explanation is necessary - this macro trick is temporary anyway in all our patch sets. Also, wouldn't repository.h be needed anyway if we reference "struct repository"? I would replace this section with the "As with the previous commits" explanation you have in PATCH 3/9 and others.
