On Mon, Apr 23, 2018 at 5:34 PM, brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Apr 23, 2018 at 04:43:27PM -0700, Stefan Beller wrote: >> This involves also adapting sha1_object_info_extended and a some >> internal functions that are used to implement these. It all has to >> happen in one patch, because of a single recursive chain of calls visits >> all these functions. > > Ah, yes, I remember that recursive call chain. > > Anyway, other than the one item I mentioned earlier, this series looked > good to me. Thanks for the quick review! Well, this very paragraph that you quote also mentions *sha1*_object_info_extended, so I'll fix that, too I'll wait until tomorrow for a resend to give others the opportunity to weigh in as well. Thanks, Stefan