Hi Junio, On Thu, Apr 19, 2018 at 8:05 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> On Thu, Apr 19, 2018 at 10:57 AM, Elijah Newren <newren@xxxxxxxxx> wrote: >>> This series is a reboot of the directory rename detection series that was >>> merged to master and then reverted due to the final patch having a buggy >>> can-skip-update check, as noted at >>> https://public-inbox.org/git/xmqqmuya43cs.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/ >>> This series based on top of master. > > The series as-is is fine, I think, from the maintainer's point of > view. Thanks. Sorry to be a pest, but now I'm unsure how I should handle the next round. I've got: - two minor fixup commits that can be trivially squashed in (not yet sent), affecting just the final few patches - a "year" vs "years" typo in commit message of patch 32 (which is now in pu as commit 3daa9b3eb6dd) - an (independent-ish) unpack_trees fix (Message-ID: 20180421193736.12722-1-newren@xxxxxxxxx), possibly to be supplemented by another fix/improvement suggested by Duy Should I... - send out a reroll of everything, and include the unpack_trees fix(es) in the series? - just resend patches 32-36 with the fixes, and renumber the patches to include the unpack_trees stuff in the middle? - just send the two fixup commits, ignore the minor typo, and keep the unpack_trees fix(es) as a separate topic that we'll just want to advance first? - something else? Thanks, Elijah
