On Tue, Apr 17, 2018 at 03:07:46PM +0900, Junio C Hamano wrote: > * tb/config-type (2018-04-10) 2 commits > - builtin/config.c: support `--type=<type>` as preferred alias for `--<type>` > - builtin/config.c: treat type specifiers singularly > (this branch is used by tb/config-default.) > > The "git config" command uses separate options e.g. "--int", > "--bool", etc. to specify what type the caller wants the value to > be interpreted as. A new "--type=<typename>" option has been > introduced, which would make it cleaner to define new types. > > Expecting a final reroll. > cf. <20180411034941.GA63158@syl.local> > This looked more or less ready, IIRC > > > * tb/config-default (2018-04-10) 3 commits > - builtin/config: introduce `color` type specifier > - config.c: introduce 'git_config_color' to parse ANSI colors > - builtin/config: introduce `--default` > (this branch uses tb/config-type.) > > "git config --get" learned the "--default" option, to help the > calling script. Building on top of the tb/config-type topic, the > "git config" learns "--type=color" type. Taken together, you can > do things like "git config --get foo.color --default blue" and get > the ANSI color sequence for the color given to foo.color variable, > or "blue" if the variable does not exist. > > Will wait on the tb/config-type topic. Hi Junio, Thank you for picking up both of these topics. I sent a final reroll to tb/config-type, which I see has made it successfully to 'pu'. I noticed that tb/config-default, however, only landed two commits: - builtin/config: introduce `color` type specifier - config.c: introduce 'git_config_color' to parse ANSI colors but not: - builtin/config: introduce `--default` As such, I am able to build on 'pu', but the `--default` option is missing: ~/g/git (pu) $ ./git-config --type=color --default red core.doesntexist error: unknown option `default' Please advise. Thanks, Taylor
