On 21 April 2018 at 05:45, Taylor Blau <me@xxxxxxxxxxxx> wrote: > diff --git a/grep.c b/grep.c > index 29bc799ecf..7872a5d868 100644 > --- a/grep.c > +++ b/grep.c > @@ -95,6 +95,10 @@ int grep_config(const char *var, const char *value, void *cb) > opt->linenum = git_config_bool(var, value); > return 0; > } > + if (!strcmp(var, "grep.columnnumber")) { > + opt->columnnum = git_config_bool(var, value); > + return 0; > + } > > if (!strcmp(var, "grep.fullname")) { > opt->relative = !git_config_bool(var, value); > @@ -111,6 +115,8 @@ int grep_config(const char *var, const char *value, void *cb) > color = opt->color_function; > else if (!strcmp(var, "color.grep.linenumber")) > color = opt->color_lineno; > + else if (!strcmp(var, "color.grep.columnumber")) > + color = opt->color_columnno; missing 'n' (s/umnum/umnnum/). Those characters are almost perfectly designed for hiding precisely this mistake. ;-)