On Fri, Apr 20, 2018 at 6:36 AM, Ben Peart <Ben.Peart@xxxxxxxxxxxxx> wrote: > Add the ability to control the aggressive flag passed to read-tree via a config setting. This feels like a workaround to the performance problems with index updates in merge-recursive.c. That said, it makes sense to me to do this when rename detection is turned off. In fact, I think you'd automatically want to set aggressive to true whenever rename detection is turned off (whether by your merge.renames option or the -Xno-renames flag). I can't think of any reason this setting would be useful separate from turning rename detection off, and it'd actively harm rename detection performance improvements I have in the pipeline. I'd really prefer to not add this option, and instead combine the setting of aggressive with the other flag. Do you have an independent reason for wanting this? Thanks, Elijah
