----- On Apr 19, 2018, at 8:03 PM, Junio C Hamano gitster@xxxxxxxxx wrote: > Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> writes: > >>>> I'd further say that these new CC-sources should be disabled by >>>> default and made opt-in to avoid surprising existing users. >>> >>> But I disagree with this. The current behaviour is surprising to >>> existing users, to the point where people are writing their own scripts >>> to replace git send-email (which seems crazy to me). >> >> We could perhaps go with a whitelist approach. The four >> main match I would be tempted to add are: Acked-by, Reported-by, >> Reviewed-by, and Tested-by. > > A tool that suddenly starts sending e-mails to more addresses > without letting the end-users know when and why the change in > behaviour happened is a source of irritated "somebody made a stupid > change to git-send-email without telling us that caused unwanted > e-mails sent to unexpected places and embarrassed me" bug reports. > I do agree with a whitelist approach from that point of view, and in > the initial rollout of the feature, that whitelist should be limited > to what we already send out. > > The users who learn about this new feature can opt into whitelisting > the common 4 above before we enable them by default. FWIW, I > personally think these will be a sensible default (in addition to > what we already Cc). I however prefer an approach to introduce > these more gradually. Sure, introducing changes like this needs to be done gradually. Thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
