Re: [PATCH] fsck: do not crash on tag objects which do not contain an empty line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 2007 June 07, Johannes Schindelin wrote:

> +		error("tag %s does not contain any tag?", refname);

Seems a bad error message to me.  Also, why is it a question?

 git: tag does not contain a tag
 user: WTF?

Perhaps, "The annotated tag, %s, does not contain a message", or similar?

Also - is this really something that should be complained about?  I'm 
wondering why it is important that tag objects contain a message?  For 
example, tagging a release as v1.0.0 - it's important to record who tagged 
it, and when it was tagged, but I can certainly envisage there not being a 
message to go with it.  Most tags in the git repository are just a repeat of 
the tag name in the message.




Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@xxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux