I think this version (V4) should reflect the latest round of feedback. Please let me know if there are any other questions or outstanding work to finish here. I have submitted a patch series to have a second component use this memory pool [1]. Thank you [1] https://public-inbox.org/git/20180417163400.3875-2-jamill@xxxxxxxxxxxxx/ -----Original Message----- From: Jameson Miller Sent: Wednesday, April 11, 2018 2:38 PM To: git@xxxxxxxxxxxxxxx Cc: gitster@xxxxxxxxx; peff@xxxxxxxx; sunshine@xxxxxxxxxxxxxx; ramsay@xxxxxxxxxxxxxxxxxxxx; Jameson Miller <jamill@xxxxxxxxxxxxx> Subject: [PATCH v4 0/3] Extract memory pool logic into reusable component Thank you everyone for taking the time review and provide feedback on this patch series. Changes from v3: - Based patch off of new commit, to resolve merge conflict. - Updated log message in 2/3 based on feedback. - Squashed patch from Ramsay Jones into 2/3 to fix warning from sparse. - Updated variable names in 2/3 to reflect updated usage of variable. Jameson Miller (3): fast-import: rename mem_pool type to mp_block fast-import: introduce mem_pool type Move reusable parts of memory pool into its own file Makefile | 1 + fast-import.c | 77 +++++++++++++---------------------------------------------- mem-pool.c | 55 ++++++++++++++++++++++++++++++++++++++++++ mem-pool.h | 34 ++++++++++++++++++++++++++ 4 files changed, 106 insertions(+), 61 deletions(-) create mode 100644 mem-pool.c create mode 100644 mem-pool.h -- 2.14.3
