There have been no new comments for the last few days. I know Jeff
King will be away for the next two weeks, but should we still move
forward with this? The initial reactions to the idea seemed positive.
Best regards
Harald
On Mon, Apr 9, 2018 at 3:42 AM, Harald Nordgren
<haraldnordgren@xxxxxxxxx> wrote:
> From: Jeff King <peff@xxxxxxxx>
>
> We have a helper function to allocate ref_array_item
> structs, but it only takes a subset of the possible fields
> in the struct as initializers. We could have it accept an
> argument for _every_ field, but that becomes a pain for the
> fields which some callers don't want to set initially.
>
> Instead, let's be explicit that it takes only the minimum
> required to create the ref, and that callers should then
> fill in the rest themselves.
>
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> Signed-off-by: Harald Nordgren <haraldnordgren@xxxxxxxxx>
> ---
> ref-filter.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/ref-filter.c b/ref-filter.c
> index ade97a848..c1c3cc948 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -1824,15 +1824,18 @@ static const struct object_id *match_points_at(struct oid_array *points_at,
> return NULL;
> }
>
> -/* Allocate space for a new ref_array_item and copy the objectname and flag to it */
> +/*
> + * Allocate space for a new ref_array_item and copy the name and oid to it.
> + *
> + * Callers can then fill in other struct members at their leisure.
> + */
> static struct ref_array_item *new_ref_array_item(const char *refname,
> - const struct object_id *oid,
> - int flag)
> + const struct object_id *oid)
> {
> struct ref_array_item *ref;
> +
> FLEX_ALLOC_STR(ref, refname, refname);
> oidcpy(&ref->objectname, oid);
> - ref->flag = flag;
>
> return ref;
> }
> @@ -1927,12 +1930,13 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,
> * to do its job and the resulting list may yet to be pruned
> * by maxcount logic.
> */
> - ref = new_ref_array_item(refname, oid, flag);
> + ref = new_ref_array_item(refname, oid);
> ref->commit = commit;
> + ref->flag = flag;
> + ref->kind = kind;
>
> REALLOC_ARRAY(ref_cbdata->array->items, ref_cbdata->array->nr + 1);
> ref_cbdata->array->items[ref_cbdata->array->nr++] = ref;
> - ref->kind = kind;
> return 0;
> }
>
> @@ -2169,7 +2173,7 @@ void pretty_print_ref(const char *name, const struct object_id *oid,
> const struct ref_format *format)
> {
> struct ref_array_item *ref_item;
> - ref_item = new_ref_array_item(name, oid, 0);
> + ref_item = new_ref_array_item(name, oid);
> ref_item->kind = ref_kind_from_refname(name);
> show_ref_array_item(ref_item, format);
> free_array_item(ref_item);
> --
> 2.14.3 (Apple Git-98)
>
