Stefan Beller <sbeller@xxxxxxxxxx> writes: > By making the oidmap a pointer, we eliminate the need for > the global boolean variable 'replace_object_prepared'. That is not quite a justification for this change, as making it a pointer (and paying for the malloc(3) overhead) is not the only way to remove the variable (i.e. the "has this been initialized?" bit can be moved to "struct raw_object_store"). One possible advantage of this approach, I guess, is that we would more quickly catch code that tries to access replace-map without initializing it.