Hi, Attached is the seventh re-roll of my series to support '--type=<type>' instead of '--<type>' in 'git-config(1)'. Since v6, I have changed only the wording in Documentation/git-config.txt, which Eric and I reached consensus upon in a sub-thread [1]. Per Eric's suggestion, I have also included an inter-diff between this re-roll and the one previous for easier consumption. I anticipate that since relatively little has changed since the last re-roll, that this will be the final re-roll of this series. I apologize that the re-roll count has gotten so high, though I am glad that we hashed out the important details. I have a better idea of how to discuss on this list without increasing the re-roll count so much. Thanks in advance for your review :-). Thanks, Taylor [1]: https://public-inbox.org/git/CAPig+cQXJuLWpxfwhQ98a23wfAAzKZpkOvqWBdXaKKHLiW-7Uw@xxxxxxxxxxxxxx/ Taylor Blau (2): builtin/config.c: treat type specifiers singularly builtin/config.c: support `--type=<type>` as preferred alias for `--type` Documentation/git-config.txt | 71 ++++++++++++++++++--------------- builtin/config.c | 76 +++++++++++++++++++++++------------- t/t1300-repo-config.sh | 29 ++++++++++++++ 3 files changed, 117 insertions(+), 59 deletions(-) Inter-diff (since v6): diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index b7686fcbe3..a1e3ffe750 100644 --- a/Documentation/git-config.txt +++ b/Documentation/git-config.txt @@ -38,12 +38,10 @@ existing values that match the regexp are updated or unset. If you want to handle the lines that do *not* match the regex, just prepend a single exclamation mark in front (see also <<EXAMPLES>>). -The `--type` option requests 'git config' to ensure that the configured values -associated with the given variable(s) are of the given type. When given -`--type`, 'git config' will ensure that the variable(s) are of the given type -and convert the value to the canonical form. If no type specifier is passed, no -checks or transformations are performed on the value. Callers may unset any -pre-existing type specifiers with `--no-type`. +The `--type=<type>` option instructs 'git config' to ensure that incoming and +outgoing values are canonicalize-able under the given <type>. If no +`--type=<type>` is given, no canonicalization will be performed. Callers may +unset an existing `--type` specifier with `--no-type`. When reading, the values are read from the system, global and repository local configuration files by default, and options -- 2.17.0
