On Sat, Apr 7, 2018 at 12:42 PM, Harald Nordgren
<haraldnordgren@xxxxxxxxx> wrote:
> From: Jeff King <peff@xxxxxxxx>
>
> Internally we store a "struct object_id", and all of our
> callers have one to pass us. But we insist that they peel it
> to its bare-sha1 hash, which we then hashcpy() into place.
> Let's pass it around as an object_id, which future-proofs us
> for a post-sha1 world.
> ---
You incorrectly dropped Peff's sign-off[1] when re-sending the patches
he authored in the series. And, your sign-off should follow his.
Also, if you made any changes to Peff's patch, it's a good idea to
state so with a bracketed comment at the end of the commit message
(before the sign-offs). For instance:
[hn: tweaked doodle blap]
or such.
[1]: https://public-inbox.org/git/20180406185831.GA11108@xxxxxxxxxxxxxxxxxxxxx/
