Hi Jake,
On Thu, 5 Apr 2018, Jacob Keller wrote:
> On Thu, Apr 5, 2018 at 3:48 PM, Johannes Schindelin
> <johannes.schindelin@xxxxxx> wrote:
> > From: Ryan Dammrose <ryandammrose@xxxxxxxxx>
> >
> > This is an attempt to resolve an issue I experience with people that are
> > new to Git -- especially colleagues in a team setting -- where they miss
> > that their push to a remote location failed because the failure and
> > success both return a block of white text.
> >
> > An example is if I push something to a remote repository and then a
> > colleague attempts to push to the same remote repository and the push
> > fails because it requires them to pull first, but they don't notice
> > because a success and failure both return a block of white text. They
> > then continue about their business, thinking it has been successfully
> > pushed.
> >
> > This patch colorizes the errors and hints (in red and yellow,
> > respectively) so whenever there is a failure when pushing to a remote
> > repository that fails, it is more noticeable.
> >
> > [jes: fixed a couple bugs, added the color.{advice,push,transport}
> > settings, refactored to use want_color_stderr().]
> >
> > Signed-off-by: Ryan Dammrose ryandammrose@xxxxxxxxx
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> >
> > squash! push: colorize errors
> >
> > Stop talking about localized errors
>
> Guessing you intended to remove this part after squashing?
Hah! You caught be red-handed.
This was intended as a reminder, as you probably guessed, to remove any
mentions of "localized errors" because I had verified that there was no
localized error message; besides, I replaced the call to strstr() looking
at the error message with a call to push_had_errors() (i.e. using the
ref_status instead). So there are definitely no issues about localized
errors left.
> Didn't see anything else to comment on in the actual code.
Thank you,
Dscho
