On Thu, Apr 05, 2018 at 06:12:02PM -0400, Jeff King wrote: > On Wed, Apr 04, 2018 at 07:02:38PM -0700, Taylor Blau wrote: > > > +test_expect_success '--no-type unsets type specifiers' ' > > + echo "10" > expect && > > + git config --type=bool --no-type core.number >actual && > > + test_cmp expect actual > > +' > > Actually, one minor nit (not worth a re-roll, but Junio may want to mark > it up): drop the space in "> expect". I'm re-rolling for some of the other review this round picked up, so I've included this in the forthcoming v5. Thanks, Taylor