On Thu, Apr 05, 2018 at 05:58:00PM -0400, Jeff King wrote: > On Wed, Apr 04, 2018 at 07:00:34PM -0700, Taylor Blau wrote: > > > I have attached a fourth re-roll of my series to introduce > > "--type=<type>" in "git config", and prefer it to "--<type>". > > > > In particular, since the last update, I have changed the following: > > > > - Clearer wording in the second patch per Eric's suggestion. > > > > - Stopped spelling the required argument to "--type=" as "[type]", and > > instead as "<type>" (cc: Eric). > > > > - Changed "unexpected" to "unrecognized" in the fatal message when we > > don't know how to interpret the argument to "--type". > > This iteration looks good to me, assuming that last-one-wins is still > the direction we want to go. I'm open to the notion that the cleanup is > not worth the change in behavior. It is IMHO, but obviously it's > somewhat subjective. I am too, unless people on this thread have strong feelings otherwise. Thanks, Taylor
