Alex Riesen <raa.lkml@xxxxxxxxx> writes:
> The problem is visible when cloning a local repo. The cloned
> repository will have the origin url setup incorrectly: the origin name
> will be copied verbatim in origin url of the cloned repository.
> Normally, the name is to be expanded into absolute path.
Thanks.
> diff --git a/git-clone.sh b/git-clone.sh
> index fdd354f..d45618d 100755
> --- a/git-clone.sh
> +++ b/git-clone.sh
> @@ -20,7 +20,7 @@ usage() {
> get_repo_base() {
> (
> cd "`/bin/pwd`" &&
> - cd "$1" &&
> + cd "$1" || cd "$1.git" &&
> {
> cd .git
> pwd
We would probably need a to clean up this test a bit, though.
When we write our tests, we tend to forget testing the cases
where things ought to fail.
I'll probably redo the test myself, but for the record...
- Please never "unset" GIT_CONFIG. We do not want the tests to
get affected with /etc/gitconfig or $HOME/.gitconfig;
- We would also want to test the cases where a bare repository
x exists and x.git does not, and try cloning it into y and z
respectively. Obviously the former should work and the
latter should fail.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
