On 29/03/18 19:32, Junio C Hamano wrote: > Phillip Wood <phillip.wood@xxxxxxxxxxxx> writes: > >> From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> >> >> Since v2 I've updated the patches to use '-' instead of '^' to invert >> the selection to match the rest of add -i and clean -i. >> >> These patches build on top of the recount fixes in [1]. The commit >> message for the first patch describes the motivation: >> >> "When I end up editing hunks it is almost always because I want to >> stage a subset of the lines in the hunk. Doing this by editing the >> hunk is inconvenient and error prone (especially so if the patch is >> going to be reversed before being applied). Instead offer an option >> for add -p to stage individual lines. When the user presses 'l' the >> hunk is redrawn with labels by the insertions and deletions and they >> are prompted to enter a list of the lines they wish to stage. Ranges >> of lines may be specified using 'a-b' where either 'a' or 'b' may be >> omitted to mean all lines from 'a' to the end of the hunk or all lines >> from 1 upto and including 'b'." > > I haven't seen any review comments on this round, and as I am not a > heavy user of "add -i" interface (even though I admit that I > originally wrote it), I haven't had a chance to exercise the code > myself in the two weeks since the patches have been queued in my > tree. > > I am inclihned to merge them to 'next' soonish, but please stop me > if anybody (including the original author) has further comments. > > Thanks. > Hi Junio, if no one else has any comments, then I think it's ready for next. I've not used this latest incarnation much but I've used the previous versions quite a bit. Best Wishes Phillip
