2018-03-29 17:41 GMT+03:00 Christian Couder <christian.couder@xxxxxxxxx>: > On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@xxxxxxxxx> wrote: >> Move helper function from strbuf to ref-filter. >> Get rid of some memory leaks. > > The above seems to be the changes since v5. Usually in a cover letter > (patch 0/X) there is both information about the goal of the patch > series and the changes since last version. > > Repeating the goal in each version is useful for reviewers who might > not have time to look at the patch series before, or who might have > forgotten about it. Thank you, I wasn't thinking about it that way. I agree, it's important. Description: The main idea of the patch is, if you want to format the output by ref-filter, you should have an ability to work with errors and final message by yourself if you want to. So I decided not to touch signature of show_ref_array_item(), but to move all die() invocations to it. So that we could invoke format_ref_array_item() and be sure that we could handle errors by ourselves, and we also get formatted message so we could continue working with it if we want to. Thank you, Olga
