Thanks Jeff.
I appreciate your time. Quick Q... is there a way to track the patch through to release? If not I can just scan release notes/etc so no worries.
Cheers,
Erik
On 3/29/18, 2:51 PM, "Jeff King" <peff@xxxxxxxx> wrote:
On Thu, Mar 29, 2018 at 11:00:56AM -0700, Erik E Brady wrote:
> The credential subsystem can trigger SIGPIPE when writing to an
> external helper if that helper closes its stdin before reading the
> whole input. Normally this is rare, since helpers would need to read
> that input to make a decision about how to respond, but:
>
> 1. It's reasonable to configure a helper which only handles "get"
> while ignoring "store". Such a handler might not read stdin
> for "store", thereby rapidly closing stdin upon helper exit.
>
> 2. A broken or misbehaving helper might exit immediately. That's an
> error, but it's not reasonable for it to take down the parent Git
> process with SIGPIPE.
>
> Even with such a helper, seeing this problem should be rare. Getting
> SIGPIPE requires the helper racily exiting before we've written the
> fairly small credential output.
>
> Signed-off-by: Erik E Brady <brady@xxxxxxxxx>
> ---
> credential.c | 3 +++
> 1 file changed, 3 insertions(+)
This version looks good to me. Thanks!
-Peff
