Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 29, 2018 at 8:18 AM, Johannes Schindelin
<johannes.schindelin@xxxxxx> wrote:

> So what is the argument against this extra care to detect comments? Well, if
> you have something like this:
>
>         [section]
>                 ; Here we comment about the variable called snarf
>                 snarf = froop
>
> and we run `git config --unset section.snarf`, we end up with this config:
>
>         [section]
>                 ; Here we comment about the variable called snarf
>
> which obviously does not make sense. However, that is already established
> behavior for quite a few years, and I do not even try to think of a way how
> this could be solved.

By commenting out the key/value pair instead of deleting it.
It's called --unset, not --delete ;)

Now onto reviewing the patches.

Stefan



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux