On Wed, Mar 28, 2018 at 8:02 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > On Wed, Mar 28, 2018 at 10:55 AM, Nguyễn Thái Ngọc Duy > <pclouds@xxxxxxxxx> wrote: >> +/** >> + * Return the current directory, fall back to $PWD if the >> + * current directory does not exist. >> + */ >> +extern void strbuf_get_pwd_cwd(struct strbuf *sb); > > Please see 89a9f2c862 (CodingGuidelines: mention "static" and "extern", > 2018-02-08) and drop the extern if you need to reroll. I'm aware (and in favor) of that actually. But this whole strbuf.h uses extern. Either I had to delete all extern first, or go with old style and maybe do the whole deletion later. I chose the former. Maybe be I'll delete all "extern" as a prep patch. -- Duy
