"Lars Hjemli" <hjemli@xxxxxxxxx> writes: > This is just a simple refactoring of modules_init() with no change in > functionality. > > Signed-off-by: Lars Hjemli <hjemli@xxxxxxxxx> > --- > > On Tue, 05 Jun 2007 12:40:50 +0200, Johannes Sixt <J.Sixt@xxxxxxxxxxxxx> wrote: > >> Lars Hjemli wrote: >>> + module_clone "$path" "$url" || exit $? >> >> Minor nit: The idiom that is commonly used in situations like this (see >> other git-* shell scripts): >> >> module_clone "$path" "$url" || exit >> >> because exit without argument uses the code of the last command >> executed. >> > > Thanks, I'll follow up with matching changes to [patch 2/2]. > This seems to be WS munged by your mailer. > ... > + die "Clone of submodule '$path' failed" > +} > + > # > # Run clone + checkout on missing submodules > # > @@ -40,20 +67,6 @@ modules_init() > # repository - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
