On Tue, Mar 27, 2018 at 12:02 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> The set of extra warnings we enable when DEVELOPER has to be >> conservative because we can't assume any compiler version the >> developer may use. Detect the compiler version so we know when it's >> safe to enable -Wextra and maybe more. > > This is a good idea in general, but we are not quite ready without > some fixups. > > Here is a quick summary (not exhaustive) from my trial merge to 'pu' > (which will be reverted before today's integration is pushed out). > > - json-writer.c triggers -Werror=old-style-decl > > - t/helper/test-json-writer.c triggers Werror=missing-prototypes > quite a few times. I expected these (and it was a good reason to push this patch forward). I think people also reported style problems with this series. > > - connect.c -Werror=implicit-fallthough around die_initial_contact(). > This I did not expect. But I just looked again and I had this option explicitly turned off in config.mak! gcc-6.4 and gcc-4.9 do not complain about this. gcc-7.3 does. What's your compiler/version? -- Duy
