Even if the RUNTIME_PREFIX feature originates from Git for Windows, the current patch series is different enough in its design that it leaves the Windows-specific RUNTIME_PREFIX handling in place: On Windows, we still have to override argv[0] with the absolute path of the current `git` executable. Let's just port the Windows-specific code over to the new design and get rid of that argv[0] overwriting. This also partially addresses a very obscure problem reported on the Git for Windows bug tracker, where misspelling a builtin command using a creative mIxEd-CaSe version could lead to an infinite ping-pong between git.exe and Git for Windows' "Git wrapper" (that we use in place of copies when on a file system without hard-links, most notably FAT). Dan, I would be delighted if you could adopt these patches into your patch series. Johannes Schindelin (2): exec_cmd: provide a new-style RUNTIME_PREFIX helper for Windows mingw/msvc: use the new-style RUNTIME_PREFIX helper Makefile | 8 ++++++++ compat/mingw.c | 5 ++--- config.mak.uname | 2 ++ exec_cmd.c | 22 ++++++++++++++++++++++ 4 files changed, 34 insertions(+), 3 deletions(-) -- 2.7.4
