Hi Eric,
On Sun, 25 Mar 2018, Eric Sunshine wrote:
> On Sat, Mar 24, 2018 at 2:23 PM, Paul-Sebastian Ungureanu
> <ungureanupaulsebastian@xxxxxxxxx> wrote:
> > Currently, because git stash is not fully converted to C, I
> > introduced a new helper that will hold the converted commands.
> > ---
> > diff --git a/builtin/stash--helper.c b/builtin/stash--helper.c
> > @@ -0,0 +1,52 @@
> > +int cmd_stash__helper(int argc, const char **argv, const char *prefix)
> > +{
> > + int cmdmode = 0;
> > +
> > + struct option options[] = {
> > + OPT_CMDMODE(0, "list", &cmdmode,
> > + N_("list stash entries"), LIST_STASH),
> > + OPT_END()
> > + };
>
> Is the intention that once git-stash--helper implements all 'stash'
> functionality, you will simply rename git-stash--helper to git-stash?
> If so, then I'd think that you'd want it to accept subcommand
> arguments as bare words ("apply", "drop") in order to be consistent
> with the existing git-stash command set, not in dashed form
Why not start with cmdmode, and then add a single patch that *also*
accepts argv[1] as a bare-word cmdmode?
This could even potentially be a patch to parse-options.[ch] that
introduces, say, PARSE_OPT_ALLOW_BARE_CMDMODE.
Ciao,
Dscho
