On Friday 16 March 2018 02:03 AM, Junio C Hamano wrote: > Quite honestly, I am not sure if this amount of new code that > results in sentence lego is really worth it. Speaking specifically about the new code for the sentence lego: I currently lack knowledge of a better way to achieve the same outcome the new code does. Let me know if there is a better way. > Is it so wrong for > "branch -m tset master" to complain that master already exists so no > branch can be renamed to it? > Speaking in general about the patch itself: though I still find the fact that "the error about an inexistent source branch seconds the error about an existing destination branch" to be a little unintuitive, I actually went on to reboot this after a long time as this also seems to bring consistency in the error messages related to moving a branch. It seems that the commit message requires an update as it currently seems to be misleading as it currently doesn't specify the motivation completely. That said, I won't be against dropping the patch if it seems to be adding less value at the cost of more code. -- Kaartic
Attachment:
signature.asc
Description: OpenPGP digital signature
