Hi Paul-Sebastian, On Fri, 23 Mar 2018, Paul-Sebastian Ungureanu wrote: > On Tue, 2018-03-20 at 23:08 +0100, Christian Couder wrote: > > Hi, > > > > On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu > > <ungureanupaulsebastian@xxxxxxxxx> wrote: > > > > > > * Convert function: this step is basically makes up the goal of > > > this > > > project. > > > > Could you explain a bit more how you would convert a function? Or > > could you explain for example how you would convert "git stash list" > > below? > > In order to convert a command, all the functions which are used by the > command must be converted first. The conversion will start with the > bottom-level functions, which do not have any dependencies. > > For example, to convert "git stash list", the parser will call > “list_stash”, which will call “have_stash”. The conversion of these > functions will be made in reverse order they were mentioned (have_stash > first and then list_stash). > > It is very important to know the Git source well in order to avoid > reimplementing functionality. In this case “have_stash()” is somehow > already implemented as “get_oid(ref_stash, &obj)”. Very good > [... proposal ...] This is a pretty good proposal. The initial draft at converting `stash list` is a good start (it will need to be converted to avoid spawning an extra process, but that is something we can do incrementally, together). Ciao, Johannes
