2018-03-15 16:55 GMT+01:00 Junio C Hamano <gitster@xxxxxxxxx>: > Jeff King <peff@xxxxxxxx> writes: > >> Hrm. I took the goal to mean that we used to exit with a failing "1" in >> this case, and now we would switch to a more-specific "2". And I think >> that matches the behavior of the patch: >> >> -test $commits -eq 0 && die "Found nothing to rewrite" >> +test $commits -eq 0 && die_with_status 2 "Found nothing to rewrite" >> >> Am I missing something? > > No, other than that I wrote my response before sufficiently > caffeinated ;-) > > Thanks, then other than the lack of doc updates, I do not see an > issue. Great! So, I'm ready to update the patch, including the doc changes, which will be the one suggested by Jeff: EXIT STATUS ----------- On success, the exit status is `0`. If the filter can't find any commits to rewrite, the exit status is `2`. On any other error, the exit status may be any other non-zero value. And yes, I'm a brand new contributor, so here's my question: how should I send an updated patch? I can't find anything related to this in https://github.com/git/git/blob/master/Documentation/SubmittingPatches PS: nice community! -- Michele
