On 03/10, Marc Strapetz wrote:
> On 09.03.2018 23:18, Junio C Hamano wrote:
> >Marc Strapetz <marc.strapetz@xxxxxxxxxxx> writes:
> >
> >>Thanks, I can confirm that the misleading warning message is fixed.
> >>
> >>What I've noticed now is that when using -u option, Git won't warn if
> >>the pathspec is actually not matching a file. Also, an empty stash may
> >>be created.
> >
> >Soooo..., does it mean that the patch Thomas posted and you
> >confirmed trades one issue with another issue with a similar
> >graveness?
I've been meaning to follow up on this, but haven't found the time to
do so yet, sorry.
> From my understanding these are two separate problems for which the new one
> was somewhat hidden by the one Thomas has fixed: Thomas has fixed
> post-processing code after the stash has already been saved away. The
> problem I'm referring to is a missing check for invalid paths before the
> stash is saved away.
Yeah, just to demonstrate what the new problem Marc describes is,
currently 'git stash push -u <unknown>' would produce the following
output, and create a new stash:
$ git stash push -u unknown
Saved working directory and index state WIP on master: 7e31236f65 Sixth batch for 2.17
fatal: pathspec 'unknown' did not match any files
error: unrecognized input
$
With the patch I posted it would just print
$ git stash push -u unknown
Saved working directory and index state WIP on master: 7e31236f65 Sixth batch for 2.17
$
and produce a new stash as before. Both of those end up confusing to
the user, dunno which one is better. What really should happen is
$ git stash push -u unknown
No local changes to save
$
and not creating a stash. So these were many words to basically say
that I think my patch is still the right thing to do, but it may or
may not confuse the user more if they are hitting the other bug Marc
noted. Either way I'll try to address this as soon as I can get some
time to look at it.
> -Marc
