Re: [PATCH v10 6/9] convert: add 'working-tree-encoding' attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v10 6/9] convert: add 'working-tree-encoding' attribute
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Wed, 07 Mar 2018 14:57:40 -0800
Cc: Eric Sunshine <sunshine@xxxxxxxxxxxxx>, Lars Schneider <lars.schneider@xxxxxxxxxxxx>, Git List <git@xxxxxxxxxxxxxxx>, Torsten Bögershausen <tboegi@xxxxxx>, Johannes Sixt <j6t@xxxxxxxx>, Jeff King <peff@xxxxxxxx>, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>, Johannes Schindelin <Johannes.Schindelin@xxxxxx>
In-reply-to: <66370A41-A048-44E7-9BF8-4631C50AAE63@gmail.com> (Lars Schneider's message of "Wed, 7 Mar 2018 23:56:33 +0100")
References: <20180307173026.30058-1-lars.schneider@autodesk.com> <20180307173026.30058-7-lars.schneider@autodesk.com> <CAPig+cSvC1a5EaDfFZdJU74mZz84M=CkeOJLSDxFdXKcJYyzEw@mail.gmail.com> <66370A41-A048-44E7-9BF8-4631C50AAE63@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux)

Lars Schneider <larsxschneider@xxxxxxxxx> writes:

> Nice catch. What do you think about this solution using is_encoding_utf8()
> from utf.c?

That helper was invented exactly for a case like this, I would
think.

References:
- [PATCH v10 0/9] convert: add support for different encodings
  - From: lars . schneider
- [PATCH v10 6/9] convert: add 'working-tree-encoding' attribute
  - From: lars . schneider
- Re: [PATCH v10 6/9] convert: add 'working-tree-encoding' attribute
  - From: Eric Sunshine
- Re: [PATCH v10 6/9] convert: add 'working-tree-encoding' attribute
  - From: Lars Schneider

Prev by Date: Re: [PATCH v10 7/9] convert: check for detectable errors in UTF encodings
Next by Date: Re: [PATCH v10 9/9] convert: add round trip check based on 'core.checkRoundtripEncoding'
Previous by thread: Re: [PATCH v10 6/9] convert: add 'working-tree-encoding' attribute
Next by thread: Re: [PATCH v10 6/9] convert: add 'working-tree-encoding' attribute
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]