On Tue, Mar 6, 2018 at 6:57 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > SiddharthaMishra <sidm1999@xxxxxxxxx> writes: > >> Added a job to run clang static code analysis on the master and maint branch >> >> Signed-off-by: SiddharthaMishra <sidm1999@xxxxxxxxx> >> --- > > Why on 'master' and 'maint' and not others? Quite frankly, I find > this choice of branches rather odd, as these two branches are not > where the real development happens. If we do not want to increase > the number of jobs and limit the test only to a single branch, I > would probably pick 'next', and if we can afford two, probably > 'pu' and 'next'. I might have been misinterpreting it, but I did so because that's what it said in the microproject description. Thinking about it, I guess it does makes more sense to work on the other two branches instead. Are there any other glaring issues you see in the code?
