On Thu, Mar 01, 2018 at 11:06:45AM -0800, Junio C Hamano wrote: > Leah Neukirchen <leah@xxxxxxxx> writes: > > > You are right in calling this out an emerging new thing, but the > > second list of that page proves that it will be useful to settle on a > > common configuration, and my hope is by getting a few popular projects > > on board, others will soon follow. It certainly is easy to implement, > > and rather unintrusive. Users which don't know about this feature are > > completely unaffected. > > There certainly is chicken-and-egg problem there. Even though I > personally prefer not to see overuse of colors, I am not sure if > we the Git community as a whole would want to be involved until it > gets mainstream. As a note, turning off color can improve accessibility for some people. I have a co-worker who has deuteranomaly and virtually all colored text at the terminal poses readability problems. It would be beneficial if he could just set NO_COLOR=1 in his environment and have everything just work. For this reason, I'm in favor of taking this patch, assuming it comes with tests. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
