On Fri, Feb 23, 2018 at 01:45:57PM -0800, Brandon Williams wrote: > I think this is the price of extending the protocol in a backward > compatible way. If we don't want to be backwards compatible (allowing > for graceful fallback to v1) then we could design this differently. > Even so we're not completely out of luck just yet. > > Back when I introduced the GIT_PROTOCOL side-channel I was able to > demonstrate that arbitrary data could be sent to the server and it would > only respect the stuff it knows about. This means that we can do a > follow up to v2 at some point to introduce an optimization where we can > stuff a request into GIT_PROTOCOL and short-circuit the first round-trip > if the server supports it. If that's our end-game, it does make me wonder if we'd be happier just jumping to that at first. Before you started the v2 protocol work, I had a rough patch series passing what I called "early capabilities". The idea was to let the client speak a few optional capabilities before the ref advertisement, and be ready for the server to ignore them completely. That doesn't clean up all the warts with the v0 protocol, but it handles the major one (allowing more efficient ref advertisements). I dunno. There's a lot more going on here in v2 and I'm not sure I've fully digested it. > The great thing about this is that from the POV of the git-client, it > doesn't care if its speaking using the git://, ssh://, file://, or > http:// transport; it's all the same protocol. In my next re-roll I'll > even drop the "# service" bit from the http server response and then the > responses will truly be identical in all cases. This part has me a little confused still. The big difference between http and the other protocols is that the other ones are full-duplex, and http is a series of stateless request/response pairs. Are the other protocols becoming stateless request/response pairs, too? Or will they be "the same protocol" only in the sense of using the same transport? (There are a lot of reasons not to like the stateless pair thing; it has some horrid corner cases during want/have negotiation). -Peff
