On Tue, Feb 27, 2018 at 6:09 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Duy Nguyen <pclouds@xxxxxxxxx> writes: > >> Yes that's the intention. But after writing cover letter for v2 and >> sending it out, it looks to me that this thing must stay until all our >> code is converted to using the_hash_algo (I don't know if there are >> more to convert or it's finished already). So an alternative is we do >> the opposite: default to GIT_HASH_SHA1, but when an env variable is >> set, reset it back to NULL. This env variable will _always_ be set by >> the test suite to help us catch problems. > > If we were to do the "do not blindly initialize and always > initialize explicitly for debugging" (which I doubt is a good > direction to go in), then what you outlined above certainly is a > less evil way to do so than what the patch under discussion did, I > would think. So v3 [1] should be in good condition to go to 'pu', I think? [1] https://public-inbox.org/git/20180225111840.16421-1-pclouds@xxxxxxxxx/ -- Duy
