Sorry about that. Version 2 coming right up. On Thu, Mar 1, 2018 at 7:31 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen > <birgersp@xxxxxxxxx> wrote: >> --- > > Please sign-off on your patch. See Documentation/SubmittingPatches. > > Also, it would be helpful to write at least a short commit message > justifying the change. The reason you gave in your lead-in email[1] > might be sufficient: > > In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However, > using the numpad ENTER does not invoke the same command. > > (assuming people don't argue that numpad ENTER should be saved for > some other function). > > Thanks. > > [1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@xxxxxxxxxxxxxx/ > >> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh >> index 91c00e648..6de74ce63 100755 >> --- a/git-gui/git-gui.sh >> +++ b/git-gui/git-gui.sh >> @@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break} >> bind . <$M1B-Key-plus> {show_more_context;break} >> bind . <$M1B-Key-KP_Add> {show_more_context;break} >> bind . <$M1B-Key-Return> do_commit >> +bind . <$M1B-Key-KP_Enter> do_commit >> foreach i [list $ui_index $ui_workdir] { >> bind $i <Button-1> { toggle_or_diff click %W %x %y; break } >> bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }