On Wed, Feb 28, 2018 at 12:47 AM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > > > On 27/02/18 22:05, Junio C Hamano wrote: >> Junio C Hamano <gitster@xxxxxxxxx> writes: >> >>> OK, somehow I had the version from Ramsay on a topic branch that was >>> not merged to 'pu'. Here is the replacement for 2/2 I'd be queuing. >>> >>> We'd need SZEDER to sign it off (optionally correcting mistakes in >>> the log message) if we are going with this solution. >>> >>> Thanks. >> >> I guess I missed Ramsay's v2 which already did this >> >> <550fb3f4-8d25-c5c4-0ecd-3a4e61ea13f4@xxxxxxxxxxxxxxxxxxxx> > > Yes, and as I said in the cover letter, I wasn't too sure that > I had passed that patch along correctly. ;-) > >> so I'll use that version. We still want sign-off from Szeder, >> though. > > I would be happy with either version, or maybe Szeder would like > to tweak the commit message. In any event, it would be good to > get sign-off from Szeder. Certainly, here you go: Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> However, I'm not sure about the authorship and taking credit for the patch. We ended up taking my patch, sure, but I think Ramsay did all the real hard work, i.e. writing the commit message and, most importantly, realizing that something is wrong with that '...| sort' at the end of the line.
