Re: [PATCH] commit-graph: fix some "plain integer as NULL pointer" warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/24/2018 12:42 AM, René Scharfe wrote:
Am 24.02.2018 um 03:24 schrieb Ramsay Jones:
diff --git a/commit-graph.c b/commit-graph.c
index fc5ee7e99..c2f443436 100644
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -45,7 +45,7 @@ char *get_graph_latest_filename(const char *obj_dir)
   {
   	struct strbuf fname = STRBUF_INIT;
   	strbuf_addf(&fname, "%s/info/graph-latest", obj_dir);
-	return strbuf_detach(&fname, 0);
+	return strbuf_detach(&fname, NULL);
   }
You could also replace that function body with:

	return xstrfmt("%s/info/graph-latest", obj_dir);

René

Thanks for the feedback! I will apply these locally as I am re-rolling today.

-Stolee



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux